openbsd-ports
[Top] [All Lists]

Re: new net/netburst port

To: Vladimir Kotal <vladya@openbsd.cz>
Subject: Re: new net/netburst port
From: Peter Valchev <pvalchev@openbsd.org>
Date: Tue, 14 Aug 2001 18:11:21 -0600
Cc: ports@openbsd.org, tqbf@pobox.com
In-reply-to: <20010810140146.C22476@openbsd.cz>; from vladya@openbsd.cz on Fri, Aug 10, 2001 at 02:01:46PM +0200
Mail-followup-to: Peter Valchev <pvalchev@openbsd.org>, Vladimir Kotal <vladya@openbsd.cz>, ports@openbsd.org, tqbf@pobox.com
References: <20010810140146.C22476@openbsd.cz>
Sender: owner-ports@openbsd.org
User-agent: Mutt/1.2.5i
There are a couple of problems that I see from glance:

- the pkg/COMMENT is obsolete, now we put COMMENT lines in the
Makefiles.  I am actually surprised that you have done it that
way - what OpenBSD version do you have and how do you update your
ports tree?  This doesn't not even work in -current since backwards
compatibility has been removed.

- packages have to have a version number.  PKGNAME has to be in the form
of package-version, where 'version' should start with a digit.  If there
is no version number provided with netburst, I suggest you put the date
timestamp, i.e. netburst-20010101

- gcc -g -DDEBUG -m486 -c list.c
cc1: Invalid option `486'
Obviously, this is unacceptable.  Generally, ports should not be
i386-specific.  the -m486 optimization flag should not be hardcoded in
the program, patch it if you have to.  Additionally, it is good when it
obeys CFLAGS

- patches/patch-aa -- patches' names generally have to follow a certain
pattern.  This is taken care of by update-patches automatically, which
generates patches very easily.

I think you have to update your ports tree and see how things are done
nowadays, then go back to this and read carefully the porting
documentation.  Especially see www.openbsd.org/checklist.html after you
think you've done everything.

> Date: Fri, 10 Aug 2001 14:01:46 +0200
> From: Vladimir Kotal <vladya@openbsd.cz>
> To: ports@openbsd.org
> Cc: tqbf@pobox.com
> Subject: new net/netburst port
> Message-ID: <20010810140146.C22476@openbsd.cz>
> User-Agent: Mutt/1.2.5i
> 
> 
> Hello,
> 
> 
> I did easy port of Thomas Ptacek's netburst, which is 'fast IP scanner 
> with a flexible range-specification syntax'. (originally at
> http://www.sockpuppet.org/tqbf/goodies.html) 
> 
> I find it very usefull and actually use it very frequently. Some can find
> it more suitable than 'sumo' nmap pkg.
> 
> It can be found at:
> http://wilbury.sk/~techie/public/netburst-port.tgz
> 
> 
> v.

<Prev in Thread] Current Thread [Next in Thread>