openbsd-ports
[Top] [All Lists]

Re: The Right Way... ?

To: Ian McWilliam <i.mcwilliam@uws.edu.au>
Subject: Re: The Right Way... ?
From: Brad <brad@comstyle.com>
Date: Wed, 15 Aug 2001 10:52:16 -0400 (EDT)
Cc: <unknown@abac.com>, <ports@openbsd.org>
In-reply-to: <l03130306b79fd5771d6d@[137.154.148.203]>
Sender: owner-ports@openbsd.org
Patching is meant for modifying *existing* files. Patching a file into
existence is really stupid. Put the files in the ports files/ subdir and
copy them into ${WRKSRC} as part of a post-extract target for example.

// Brad

brad@comstyle.com
brad@openbsd.org

>At 11:03 PM -0700 2001/08/14, J.C. Roberts wrote:
>>On Wed, 15 Aug 2001 15:26:59 +1000, you wrote:
>>
>
>>>
>>>OK create a patch for them. That way they will be created at patch time and
>>>no extra copying will be needed.
>>>
>>>To do so just initially create an empty *.orig file, cp in your new include
>>>and make update-patches will do the rest.
>>>
>>>
>>
>>It's clever and I like it but I'll need to test it. Creating the empty
>>files so they can be patched would need to be done through
>>$PORTPATH\scripts\configure and as far as I know this runs _after_ the
>>patches are applied... The way I have it now works well and when/if
>>the header files are seriously changed in the OBSD source tree, the
>>port can be updated as well.
>>
>
>No you will only need the empty file to create the patch diff in the first
>place.
>
>Once you have the patch in the patch directory nothing more is needed.
>
>from scratch.
>
>make clean
>make patch
>
>cd ${WRKSRC}/blah/blah/wheretheincludefileneedstobe
>
>cp /usr/src/include/blah/blah .
>touch blah.h.orig
>
>cd portdir
>make update-patches
>
>and your new include patch will now be made.
>
>
>now when you
>make clean && make
>
>the patch cycle will now create the include you need.
>
>
>>My main concern is really licenses and sending patches to the author
>>of the program. IANAL but I'm not sure if you can have a BSD licensed
>>header file in a GPL'd program (without making a legal mess). I
>>_think_ it's OK to #include BSD (and other) licensed _system_ header
>>files in GPL programs... -I've seen it done with FreeBSD headers. Such
>>files (almost) always exist on the systems for the sake of inclusion
>>(e.g. /usr/include/*) but the ones I need are from the core source
>>tree and aren't always installed. It's a mess and I'll probably not be
>>able to offer my patch back to the author. -Sometimes I wonder about
>>the number of brain cycles wasted by non-lawyers like me trying to
>>figure out license issues... ;-)
>>
>
>Don't know. One would suggest that a BSD licence could easily be turned in
>to a GPL but not the otherway around so long as the origional copyright
>notice and the like remain. I'm no lawyer though.
>
>>Thanks for your input,
>>
>>JCR
>
>
>
>
>
>_________________________________
>Ian McWilliam.
>Technical Officer,
>School of Computing & IT
>University of Western Sydney
>Locked Bag 1797
>Penrith South DC N.S.W,
>Australia 1797.
>
>mailto:ianm@cit.uws.edu.au
>mailto:i.mcwilliam@uws.edu.au
>
>Telephone: 61 247360 757
>Fax:       61 247360 770
>__________________________________


<Prev in Thread] Current Thread [Next in Thread>